ref: SwiftUI custom redact #4392
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4392 +/- ##
=============================================
- Coverage 91.443% 91.442% -0.002%
=============================================
Files 629 629
Lines 50630 50656 +26
Branches 18344 18371 +27
=============================================
+ Hits 46298 46321 +23
- Misses 4238 4243 +5
+ Partials 94 92 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| } | ||
| } | ||
|
|
||
| @objcMembers | ||
| class SentryRedactViewHelper: NSObject { | ||
| public class SentryRedactViewHelper: NSObject { |
There was a problem hiding this comment.
I’m not super happy about making this class public, but SentrySwiftUI is an external module that needs access to it. Also, it’s impossible to misuse it in a way that would cause a crash.
There was a problem hiding this comment.
I see that you added some new methods. Maybe you can create an extra SentryRedactViewHelper just for SentrySwiftUI so you don't need to make it public?
There was a problem hiding this comment.
Not possible, I need to read it from RedactBuilder class that needs to be in the Sentry SDK.
Maybe if we split SR into a different module already we would need to worry less about this being public
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bf8571 | 1250.96 ms | 1255.36 ms | 4.40 ms |
| 2ccbd03 | 1225.13 ms | 1247.51 ms | 22.39 ms |
| d011484 | 1220.86 ms | 1237.18 ms | 16.33 ms |
| 6001822 | 1220.82 ms | 1245.02 ms | 24.20 ms |
| 3723833 | 1205.22 ms | 1216.94 ms | 11.71 ms |
| ff09c7e | 1240.94 ms | 1262.66 ms | 21.72 ms |
| b9d59f7 | 1250.71 ms | 1257.78 ms | 7.06 ms |
| 94d8eb3 | 1234.02 ms | 1249.63 ms | 15.60 ms |
| e773cad | 1219.86 ms | 1238.26 ms | 18.40 ms |
| 90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bf8571 | 20.76 KiB | 437.12 KiB | 416.36 KiB |
| 2ccbd03 | 21.58 KiB | 546.20 KiB | 524.62 KiB |
| d011484 | 21.58 KiB | 616.14 KiB | 594.56 KiB |
| 6001822 | 22.85 KiB | 410.98 KiB | 388.13 KiB |
| 3723833 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
| ff09c7e | 20.76 KiB | 427.76 KiB | 407.00 KiB |
| b9d59f7 | 22.85 KiB | 405.77 KiB | 382.93 KiB |
| 94d8eb3 | 21.58 KiB | 417.86 KiB | 396.28 KiB |
| e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
| 90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
| } | ||
| } | ||
|
|
||
| @objcMembers | ||
| class SentryRedactViewHelper: NSObject { | ||
| public class SentryRedactViewHelper: NSObject { |
There was a problem hiding this comment.
I see that you added some new methods. Maybe you can create an extra SentryRedactViewHelper just for SentrySwiftUI so you don't need to make it public?
📜 Description
Added
sentryReplayUnmaskas SwiftUI modifier.💚 How did you test it?
Sample tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps